Adrian Cole

Results 2050 comments of Adrian Cole

@jeqo warning I'm going to rebase and force push your branch

ok this is now rebased.. we have to look carefully that any new feature or tests added between brave 5.6.7 and 11 weren't accidentally scrubbed out during the rebase. It...

My take is to complete #999 which should be more straightforward. After that make a variant of it for messaging and pull logic from here into that where helpful. Rebasing...

all but one outstanding PRs have to do with messaging. When I get back to work tomorrow, I'll rebase this so we can try to clear out the queue. cc...

@jeqo I started to rebase this but it is a bit of work in the very british sense of "a bit" :P since we've drifted approach, particularly away from Adapter...

can you do us a favor and make a microprofile example similar to this? I don't have experience with this microprofile framework and want to make sure I fully understand.

@svenhaag are you just asking to remove ```java @Priority(0) // to make the span in scope visible to other filters ```

if this is not overridable in the underlying container, I'd suggest a few options: * do not use this, and instead instrument whatever the actual http client is, as that's...

@svenhaag sorry what I said isn't intuitive. I mean this ```java @Provider @ConstrainedTo(CLIENT) @Priority(1) // or whatever you want public class MyTracingClientFilter implements ClientRequestFilter, ClientResponseFilter { final TracingClientFilter delegate; @Inject...

Thanks for asking. Our change culture is intentionally reactive, to ensure that features have transparent demand, and are worth maintaining. We don't write instrumentation until someone asks for it, in...