Adrian Cole
Adrian Cole
when we do this we have to be *very* careful when wrapping as there is dispatch logic like this: ```java package org.springframework.jms.config; public abstract class AbstractJmsListenerEndpoint implements JmsListenerEndpoint { @Override...
PS the TracingMessageListener which we use internally in JmsTracing won't be used for something like Spring in the same way. the `TracingMessageListener` we have in normal JMS starts both a...
to the point about dual hierarchy: ``` java.lang.IllegalArgumentException: Could not configure endpoint with the specified container 'sleuth.webmvc.JmsConfiguration$TracingForwardingJmsListenerEndpoint$1@6ef2f7ad' Only JMS (org.springframework.jms.listener.AbstractMessageListenerContainer subclass) or JCA (org.springframework.jms.listener.endpoint.JmsMessageEndpointManager) are supported. ```
added a commit to https://github.com/openzipkin/sleuth-webmvc-example/compare/add-jms-tracing which adds receiver spans for basic message listeners. Will test more later
branch now works with all listeners except JCA. will try to wrap that up tomorrow.. We also need to test topic subscription to ensure there are no state problems (like...
@frankpolkm can you clarify if you are primarily interested in usage via sleuth or brave directly?
here's a photo of the beauty!
I was to make a similar comment to Jorg. we do want to consider what is required to do in impl vs composition. if this was the mysql driver.. with...
@anuraaga @patrickbray it just dawned on me that we should be able to get a sane default by looking at if this is a root span. If so, dump the...
ok here's a little example https://github.com/openzipkin/brave/pull/970 note you can definitely weed this stuff out with a FinishedSpanHandler meanwhile. Just look at the incoming context and see if it is root...