Adrian Cole

Results 2050 comments of Adrian Cole

PS we will eventually need `brave-instrumentation-jdbc` just like we currently need `brave-instrumentation-servlet`. For example, frameworks that layer on servlet apis, like spark and spring mvc need that jar. We will...

lovely! https://github.com/ttddyy/datasource-proxy-r2dbc#distributed-tracing

understood that this could be helpful, though I think there's only 2 copy/pastes so far. sitting on this a bit and meanwhile feel free to copy/paste. reason is that there...

related example https://github.com/openzipkin/brave/pull/1144

Something like this or otherwise that helps multiple "primary" formats should ideally be released before Brave 6. Particularly w3c trace-context will cause more mixed environments than before

to make concrete.. what I mean by B3 clone is that the format needed for the composite doesn't require putting anything in TraceContext.extra() in order to work. The way I'm...

@csabakos how are you achieving the .* baggage now? considering the propagation component is a whitelist.. Are you using BaggagePropagation (formerly ExtraFieldPropagation) to map them (similar to what sleuth does)...

related: composite was deleted out of -gcp as it wasn't actually used. in all cases so far, there's only primary/secondary https://github.com/openzipkin/zipkin-gcp/pull/174

@csabakos thanks for the link.. so what you've got there is basically B3 clone (no use of extra) which is what I hinted at for https://github.com/openzipkin/brave/pull/1060#issuecomment-628997291 meaning right now, B3Propagation...

anyway I think I'll move to "show not tell" as some of the nuance, the trouble of triple wrapping etc, performance and also feature detection wise, aren't easy to see.