Adrian Cole
Adrian Cole
due to travel, my mind is mush and I don't expect to be able to push my code tonight. If you have something to push, go for it and I...
One thing that recently came up is the request to control the propagation format https://github.com/apache/incubator-zipkin-brave/issues/915 In JMS, we currently only support "b3" only to assure that headers are safe (idempotent...
I'm pausing a bit. in case folks want to comment, here's a branch which I'm still working on so that it passes tests. I'm not completely happy with the api...
@jeqo I will rebase this branch on master and force push. then I will rebase my other PR against this
ok sorry to hold this branch hostage so long.
probably in unit tests we don't need strict scope decorator then either.. On Wed, Jul 17, 2019 at 8:10 AM Jorge Quilcate Otoya < [email protected]> wrote: > *@jeqo* commented on...
you made a lot of good notes here. mind moving some to here so we don't lose them? https://github.com/openzipkin/openzipkin.github.io/wiki/Messaging-instrumentation-abstraction On Wed, Jul 17, 2019 at 7:56 AM Jorge Quilcate Otoya...
thanks for keeping the wheels turning @jeqo !
ok with me On Sun, Jul 28, 2019, 8:52 PM Jorge Quilcate Otoya wrote: > *@jeqo* commented on this pull request. > ------------------------------ > > In > instrumentation/messaging/src/main/java/brave/messaging/MessagingAdapter.java > :...
@jeqo definitely or more precisely the amqp client also we should temporarily add sqs as there was doubt around it