Adrian Cole
Adrian Cole
I think this issue needs to become more concrete as it mentions mostly things not in this repository.
thanks, that's indeed more to the point, I guess something similar to the rxjava context stuff?
I will try to help triage this
good point, it is indeed more the other way around (our rxjava being wrapping in a context vs armeria pulling a context)
ps the referenced issues want coherence in the MDC state (as driven by brave), which is something we need to look closely at hooks on, if at reactor level.
what I mean is that in order to do this we need users to be more aware of the reactor context (which may already be taken care of in webflux).....
I'm going to start by refactoring what's in sleuth as it will teach me what functionality is needed, which will hone what we may or may not have to optimize
yep you got it. To do this for gaps (or even concurrent inbound requests for the same trace), we'd need a different cache, based on traceId I think.
I will try to add rabbit 5.x to this branch https://github.com/apache/incubator-zipkin-brave/issues/884
FYI I have a pretty big refactor on the way.. I'm in a connecting flight now, but sometime in less than 24hrs I'll push a commit that hopefully helps a...