Adrian Cole
Adrian Cole
> One thing that sounds somewhat off is we use it also as an SNI server name, which may be worth its own tag for non-HTTP. I think the problem...
I was thinking about this should be host and without the port. We already have the URL and also remoteEndpoint which has the port. We can already get the host...
fwiw the same thing mentioned about rpc applies in general for remote spans. ex kafka has a remote hostname of the broker, so does basically everything :P
> > This is a necessary feature for us in the apps that are on plain brave, my > work on opentracing has lead me toward creating a Tracer that...
anyone want to give this a try? Maybe Tracer.Builder.Tags?
incidentally, this can be accomplished with https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/handler/FinishedSpanHandler.java
In https://github.com/openzipkin/brave/pull/801 show how to do this, especially only once per-hop: ```java /** * This shows how you can add a tag once per span as it enters a process....
haven't implemented this yet, but will for 5.12 coming out soon, as we now have a template MutableSpan which is easy to add stuff to
do you mind to rebase this on latest master (note current version changed) travis hasn't worked for almost 2 weeks. master now uses GitHub actions
fyi it seems both issues are marked fixed in 5.0.4, but I looked and there is no vote thread for that version. Hence, it might be until next year https://mail-archives.apache.org/mod_mbox/hc-dev/202012.mbox/browser