Shelley Vohr
Shelley Vohr
Combining with https://github.com/electron/electron/issues/41824.
All tests pass just fine locally - wonder what's going on here 🤔 i'll poke at it
We haven't gotten a response to our questions in our comment above. With only the information that is currently in the issue, we don't have enough information to take action....
@dsanders11 fixed in [bff81a9](https://github.com/electron/fiddle/pull/1712/commits/bff81a9095612c6144ea5fb86e63e16a9ba18fae)!
@dsanders11 i think i've finally gotten it when you get a chance to re-review :D
@dsanders11 sorry for accidental review request! will comment when changes are addressed :)
It looks to be crashing here: https://github.com/electron/electron/blob/23bcca3ffcf31d6874fe3b0f69335a8e58755e43/shell/browser/ui/inspectable_web_contents.cc#L960 meaning the webContents is potentially nullptr 🤔
Closed in https://github.com/electron/apps/pull/2170
@dsanders11 no, i've only done this on posix so far! good call though, i think you're right 😅
hey @jtbandes - we've adjusted that logic a fair amount lately so there's definitely a bug or two at play here. I'll take a look - this bug should be...