Shelley Vohr
Shelley Vohr
@liliang1112 we have hundreds of issues, all of which are important to someone. Engaging like this will not help you get your issue solved faster. It will simply annoy maintainers...
@andrewsml what is `./src` in this case? is there anything in there already? There might be an issue creating multiple build types and sharing a root - is that what...
@andrewsml i'll look when I can - also, why are you running as root? you shouldn't need to.
Is this still happening?
Closing as stale given no responses.
@mai-121 please address the extra spaces on line 148 (see lint failure) and we can get this merged 😁
@mai-121 could you please rebase this on main? once that's done i'll shepherd it in :)
@jerryorr dug into this a a little bit - i do think it's actually an issue upstream. We follow the codepath for [`Page.printToPDF`](https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-printToPDF) here, and it seems to be having...
@jerryorr looking back into this - the version you have that's working looks different then what I used. I'm seeing this running with latest puppeteer: ``` const puppeteer = require('puppeteer');...
@jerryorr honestly i think it's mostly upstream still - try printing https://www.phrases.org.uk/meanings/proverbs.html to pdf with ads enabled in Chrome itself. The ads are all cross-origin iframes and they don't show...