Shelley Vohr

Results 509 comments of Shelley Vohr

@dsanders11 > In this case I'm guessing an issue is desirable because it can be referenced in an associated PR to land the upstream changes? yes, exactly. Addressed changes -...

@dsanders11 I think i'll leave it as an issue and then add a team @mention then - I'd classify it as fairly low-urgency and something that can definitely wait until...

@dfvips does this happen in Chrome itself?

@thomas-jakemeyn could you please create a standalone sample for this issue specifically? Linking your full fetch repo still requires we make assumptions and introduces extra margin for error in triage.

@CezaryKulakowski please rebase this!

@CezaryKulakowski one last rebase and I'll get this merged. Sorry for the delay.

@CezaryKulakowski could you please rebase? Issue was closed but shouldn't have been - I reopened.

@rmartins90 has this previously worked as you would expect? if yes, in which versions?

@rmartins90 `iconPath: '/resources/windows/jumplist-new-window.png'` looks like a relative path - is it? If yes, that's why it isn't working, it must be absolute!

@rmartins90 I suggest downloading one dynamically using `fetch` in the main process!