fiddle icon indicating copy to clipboard operation
fiddle copied to clipboard

refactor: improve Electron settings version table

Open codebytere opened this issue 8 months ago • 1 comments

Prior to this the table loaded all possible electron versions with no real ability to filter or search.

This PR virtualizes the list and adds input filtering.

Screenshot 2025-06-19 at 10 37 23 AM

codebytere avatar Jun 19 '25 08:06 codebytere

Coverage Status

coverage: 87.905% (-0.09%) from 87.992% when pulling 14c1ff7835570ccf51210c1a9608d17c152e72f9 on settings-version-table-improvements into 09cf3833e7b888daa5d60d7839e6ab4a2b09fd29 on main.

coveralls avatar Jun 19 '25 13:06 coveralls

@dsanders11 fixed in bff81a9!

codebytere avatar Jul 04 '25 16:07 codebytere

@codebytere, looks like that change works well if the version is at the top of the list, but if you're scrolled down the list and click one of the buttons, I'm seeing it snap back to the top of the list, and am unable to scroll down at all until the operation (download or delete) has finished.

dsanders11 avatar Jul 07 '25 09:07 dsanders11

@dsanders11 i think i've finally gotten it when you get a chance to re-review :D

codebytere avatar Jul 18 '25 09:07 codebytere

@dsanders11 sorry for accidental review request! will comment when changes are addressed :)

codebytere avatar Jul 23 '25 12:07 codebytere