Martin Schoeler

Results 17 comments of Martin Schoeler

> * Just leaving a feedback I've got about this, I'm filtering all custom fields, not only the ones with the room scope Apparently the endpoint for listing the custom...

I've changed this to a fix, since we've got reports that this feature stopped working somewhere along the way, so this PR now fixes a non functional part of the...

> ![Screen Shot 2022-09-22 at 1 49 13 PM](https://user-images.githubusercontent.com/20868078/191836044-166b231c-467f-4c04-b97b-b0cb86195dbf.png) > > If you try to open a livechat that has been closed via `current-chats` the channel will appear empty Okay,...

Hello @azevedo-joao @tashalee991 can you [open the browser devtools](https://rocket.chat/docs/contributing/reporting-issues#gathering-logs) and check the console for any errors? Thanks!

Added in https://github.com/RocketChat/Rocket.Chat/pull/31820

done in https://github.com/RocketChat/Rocket.Chat/pull/33620

This is related to https://github.com/RocketChat/Rocket.Chat/issues/31893 so I'll quote my response from there > Hey, just an update, I could not reproduce the issue locally, I will probably need a sample...

> @MartinSchoeler I experienced this same issue. I had two banners active in the rocketchat_banner table, copied for you below, when set as active:false it resolved the issue. > >...

Putting this as draft since the issue seems more complex than initially estimated

About tests, we currently mock the return of the server with an object, but the changes I've made would affect the parameters sent to the server and its return, so...