Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

refactor: Realtime `Line Charts` to TS

Open MartinSchoeler opened this issue 1 year ago • 3 comments

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-637 https://rocketchat.atlassian.net/browse/CORE-638 https://rocketchat.atlassian.net/browse/CORE-639 https://rocketchat.atlassian.net/browse/CORE-640

Steps to test or reproduce

Further comments

Depends on #33092

MartinSchoeler avatar Aug 20 '24 16:08 MartinSchoeler

⚠️ No Changeset found

Latest commit: ba9a2f8511a5128a2767fa43b822ecf64ee5078b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 20 '24 16:08 changeset-bot[bot]

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Aug 20 '24 16:08 dionisio-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.62%. Comparing base (34879cc) to head (ba9a2f8). Report is 239 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33111      +/-   ##
===========================================
+ Coverage    58.57%   59.62%   +1.04%     
===========================================
  Files         2737     2602     -135     
  Lines        65763    63784    -1979     
  Branches     14826    14289     -537     
===========================================
- Hits         38521    38030     -491     
+ Misses       24463    23033    -1430     
+ Partials      2779     2721      -58     
Flag Coverage Δ
unit 75.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 20 '24 17:08 codecov[bot]

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33111/ on branch gh-pages at 2024-10-08 17:18 UTC

github-actions[bot] avatar Oct 08 '24 12:10 github-actions[bot]

done in https://github.com/RocketChat/Rocket.Chat/pull/33620

MartinSchoeler avatar Oct 21 '24 18:10 MartinSchoeler