Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

fix: Sidebar scrolling misclick issue on iOS

Open MartinSchoeler opened this issue 1 year ago • 3 comments

SUP-582

An outdated polyfill was causing misclick issues when scrolling the channels sidebar

MartinSchoeler avatar Jul 11 '24 18:07 MartinSchoeler

Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Jul 11 '24 18:07 dionisio-bot[bot]

🦋 Changeset detected

Latest commit: 52b02c563d2ffc4087a05bde13c27aab733c73a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 11 '24 18:07 changeset-bot[bot]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.44%. Comparing base (05db8aa) to head (52b02c5). Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32769      +/-   ##
===========================================
- Coverage    55.50%   55.44%   -0.07%     
===========================================
  Files         2637     2635       -2     
  Lines        57289    57270      -19     
  Branches     11859    11855       -4     
===========================================
- Hits         31797    31752      -45     
- Misses       22801    22828      +27     
+ Partials      2691     2690       -1     
Flag Coverage Δ
e2e 53.99% <50.00%> (-0.12%) :arrow_down:
unit 72.34% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jul 11 '24 19:07 codecov[bot]

Putting this as draft since the issue seems more complex than initially estimated

MartinSchoeler avatar Jul 22 '24 13:07 MartinSchoeler