Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

[FIX] Current Chat Custom Field Filter

Open MartinSchoeler opened this issue 3 years ago • 2 comments

This PR improves the Custom Fields form on the current chats page. Allowing to filter by custom fields values instead of only the existence of the field on the room.

Since there are many fields on this page (some that uses a not-so-good enterprise implementation), I've started to incrementally move them to use react-hook-form.

This PR makes the Current Chats page table use the GenericTableV2.

This also fixes some wrong typings on the room endpoint.

Screen Shot 2022-07-08 at 4 04 54 PM

MartinSchoeler avatar Jul 08 '22 19:07 MartinSchoeler

  • Just leaving a feedback I've got about this, I'm filtering all custom fields, not only the ones with the room scope

Apparently the endpoint for listing the custom fields doesn't support filtering by scope

MartinSchoeler avatar Jul 26 '22 17:07 MartinSchoeler

I've changed this to a fix, since we've got reports that this feature stopped working somewhere along the way, so this PR now fixes a non functional part of the current chats page

MartinSchoeler avatar Jul 28 '22 15:07 MartinSchoeler

Codecov Report

Merging #26200 (148b640) into develop (8a2899f) will increase coverage by 0.74%. The diff coverage is n/a.

:exclamation: Current head 148b640 differs from pull request most recent head 1eba241. Consider uploading reports for the commit 1eba241 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26200      +/-   ##
===========================================
+ Coverage    37.96%   38.70%   +0.74%     
===========================================
  Files          778      751      -27     
  Lines        18854    18670     -184     
  Branches      1932     1453     -479     
===========================================
+ Hits          7157     7227      +70     
+ Misses       11400    11226     -174     
+ Partials       297      217      -80     
Flag Coverage Δ
e2e 38.70% <ø> (+0.74%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 11 '22 15:08 codecov[bot]