Derek Harper
Derek Harper
Hi @FacuRossi. Can you sign the CLA? We'll need it to merge your contribution. Thanks!
Also, `children` is a required property for Dialog. Please add some example children to make your new test pass then update your snapshot file using `npm run updateSnapshot`.
The snapshot test is still failing. children are required, so won't work.
Change `expanded` to `active`
Maybe if there's a way to throw a warning instead of a failed build. Sometimes we might not have control (or expertise) to make design decisions without outside input. Not...
@FacuRossi Thanks! Let us know if you identify a solution. I spent a little time trying to implement ReactDOM.createPortal() but could never actually get any content to show up with...
Yes please