react-atlas icon indicating copy to clipboard operation
react-atlas copied to clipboard

Add snapshot test to dialog.test.js

Open Darper opened this issue 7 years ago • 2 comments

The previous snapshot test was returning a false positive so it was deleted. This was caused by something in Portal.js, most likely ReactDOM.unstable_renderSubtreeIntoContainer() which has been replaced by ReactDOM.createPortal(). Please investigate.

Darper avatar Oct 09 '18 20:10 Darper

I would like to work in this test.

FacuRossi avatar Oct 11 '18 14:10 FacuRossi

@FacuRossi Thanks! Let us know if you identify a solution. I spent a little time trying to implement ReactDOM.createPortal() but could never actually get any content to show up with the modal.

Darper avatar Oct 11 '18 14:10 Darper