react-atlas icon indicating copy to clipboard operation
react-atlas copied to clipboard

Add snapShot test for dialog component

Open FacuRossi opened this issue 7 years ago • 5 comments

FacuRossi avatar Oct 17 '18 19:10 FacuRossi

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 17 '18 19:10 CLAassistant

@FacuRossi Thanks for the pr! It looks good from looking at the diff. I'll pull it down and test it and merge in like 15 or 20 minutes I'm just finishing something up. Thanks again for the work.

hbowden avatar Oct 17 '18 19:10 hbowden

Hi @FacuRossi. Can you sign the CLA? We'll need it to merge your contribution. Thanks!

Darper avatar Oct 17 '18 19:10 Darper

Also, children is a required property for Dialog. Please add some example children to make your new test pass then update your snapshot file using npm run updateSnapshot.

Darper avatar Oct 17 '18 19:10 Darper

The snapshot test is still failing. children are required, so <Dialog /> won't work.

Darper avatar Nov 13 '18 14:11 Darper