Derek Harper

Results 9 issues of Derek Harper

A list of updates to make to Tabs, Tab, TabList, and TabPanel after doing a group code review. - Change onSelect to onChange in Tabs.js - Add onBeforeChange - Replace...

Make the following changes found during a code review of the Icon component: - Update classes in docs from "fa" to "fab" - Update docs to tell user to include...

Make the following changes found during a code review of the Card component: - Change title proptype to allow .node - At minimum, change standardFieldset to fieldset and always use...

Accordion.js - [ ] **Line 57:** Add comment to inform that we are checking for a string in case the user uses an HTML element instead of a React Node,...

JS
Component Enhancement

**Documentation** - [ ] Add margin to the right of the Avatar in the 2nd example **Code** - [ ] Create new prop for custom delimiter (don't force `/`) -...

CSS
JS
Component Enhancement

The previous snapshot test was returning a false positive so it was deleted. This was caused by something in Portal.js, most likely ReactDOM.unstable_renderSubtreeIntoContainer() which has been replaced by ReactDOM.createPortal(). Please...

JS
Tests

In order to properly have a Form component that can validate Atlas input components (TextField, TextArea, Dropdown, etc.) they need to all have one method that can be called that...

JS
Component Enhancement

I haven't been able to reproduce in the docs site, but Chrome doesn't stop the browser's autocomplete functionality if you just set autocomplete="off". There are a few suggested solutions, the...

bug
JS

The default button has a different experience on hover and click than the other buttons do. Get proper interaction from UX and update accordingly.

CSS