xu1zhou

Results 12 comments of xu1zhou

Hi @gyohuangxin , I think salvo clones and builds binary under different dirs every time make it unable to reuse the code and cache. I have a idea that we...

Some points I found after going through the code: - nighthawk calls `file_ops.get_random_dir(home_dir)` (https://github.com/envoyproxy/envoy-perf/blob/2d45a91915b8076da227371be4d6d1ee706a8670/salvo/src/lib/source_tree.py#L62-L65) to create ramdom build directory within /tmp/salvo. it's easy to create a fixed directory like `/tmp/salvo/nighthawk`...

@gyohuangxin tempobject with suffix/prefix arguments only joins specified suffix/prefix with random string as name implies. These objects are different with whole path like `/tmp/salvo/prefix-8avnbwxt-suffix` > @xu1zhou Thanks for report your...

create pr for this issue. https://github.com/envoyproxy/envoy-perf/pull/153

it seems something happend to CI test. I think it's not due to my modification cause the failed. @gyohuangxin Do you have any clue?

> @xu1zhou Hi, don't worry about the CircleCI test failure, it often fails due to the OOM. Please focus on the test results of Azure pipleines, they work fine. ![image](https://user-images.githubusercontent.com/42127654/176170946-b6417f3e-2eb3-4291-8d44-5883dfb96f92.png)...

Hi @gyohuangxin I think pipeline test has passed this time.

It's possible to give `run_command` a lower logger level to avoid log duplication in this case. But it will also affect all the other `run_command` functions.

> @xu1zhou Do you have any updates? Sorry, busy with some other thing these day. I would have a update this week.