Salvo build log output duplication

[xu1zhou]

Noted that some salvo build command's logs output from cmd_exe.run_command() as well as log.debug() twice. output from run_command(): https://github.com/envoyproxy/envoy-perf/blob/2d45a91915b8076da227371be4d6d1ee706a8670/salvo/src/lib/cmd_exec.py#L62-L65 output from envoy_builder.py: https://github.com/envoyproxy/envoy-perf/blob/2d45a91915b8076da227371be4d6d1ee706a8670/salvo/src/lib/builder/nighthawk_builder.py#L92-L94

That make it hard to distinguish key info from log. Suppose we can replace it a new run_command() without output default

below is duplicate log output FYI

2022-06-21 10:26:09,876: 3123804 [ DEBUG] [cmd_exec] Returning output: [[32mLoading:[0m 
[32mLoading:[0m 1 packages loaded
[32mAnalyzing:[0m target //benchmarks:benchmarks (2 packages loaded, 0 targets configured)
[32mAnalyzing:[0m target //benchmarks:benchmarks (59 packages loaded, 298 targets configured)
[32mAnalyzing:[0m target //benchmarks:benchmarks (59 packages loaded, 298 targets configured)
[32mAnalyzing:[0m target //benchmarks:benchmarks (59 packages loaded, 298 targets configured)
[32mINFO: [0mAnalyzed target //benchmarks:benchmarks (90 packages loaded, 4891 targets configured).
[32mINFO: [0mFound 1 target...
[32m[0 / 3][0m [Prepa] BazelWorkspaceStatusAction stable-status.txt
Target //benchmarks:benchmarks up-to-date:
  bazel-bin/benchmarks/benchmarks
[32mINFO: [0mElapsed time: 41.145s, Critical Path: 0.24s
[32mINFO: [0m4 processes: 4 internal.
[32mINFO:[0m Build completed successfully, 4 total actions
[32mINFO:[0m Build completed successfully, 4 total actions
[0m]
2022-06-21 10:26:09,876: 3123804 [ DEBUG] [nighthawk_builder] Nighthawk build output: [32mLoading:[0m 
[32mLoading:[0m 1 packages loaded
[32mAnalyzing:[0m target //benchmarks:benchmarks (2 packages loaded, 0 targets configured)
[32mAnalyzing:[0m target //benchmarks:benchmarks (59 packages loaded, 298 targets configured)
[32mAnalyzing:[0m target //benchmarks:benchmarks (59 packages loaded, 298 targets configured)
[32mAnalyzing:[0m target //benchmarks:benchmarks (59 packages loaded, 298 targets configured)
[32mINFO: [0mAnalyzed target //benchmarks:benchmarks (90 packages loaded, 4891 targets configured).
[32mINFO: [0mFound 1 target...
[32m[0 / 3][0m [Prepa] BazelWorkspaceStatusAction stable-status.txt
Target //benchmarks:benchmarks up-to-date:
  bazel-bin/benchmarks/benchmarks
[32mINFO: [0mElapsed time: 41.145s, Critical Path: 0.24s
[32mINFO: [0m4 processes: 4 internal.
[32mINFO:[0m Build completed successfully, 4 total actions
[32mINFO:[0m Build completed successfully, 4 total actions
[0m

[gyohuangxin]

Makes sense.

[xu1zhou]

create pr for this issue. https://github.com/envoyproxy/envoy-perf/pull/153

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 14 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically closed because it has not had activity in the last 104 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.