envoy-perf Fix log duplication

Add argument to control print behavior of run_command function. Disable it when unnecessary to print log.

Signed-off-by: xu1zhou [email protected]

Jun 22 '22 04:06 xu1zhou

it seems something happend to CI test. I think it's not due to my modification cause the failed. @gyohuangxin Do you have any clue?

Jun 28 '22 09:06 xu1zhou

@xu1zhou Hi, don't worry about the CircleCI test failure, it often fails due to the OOM. Please focus on the test results of Azure pipleines, they work fine.

Jun 28 '22 11:06 gyohuangxin

@xu1zhou Hi, don't worry about the CircleCI test failure, it often fails due to the OOM. Please focus on the test results of Azure pipleines, they work fine.

Thanks, will check reason for that

Jun 30 '22 02:06 xu1zhou

Hi @gyohuangxin I think pipeline test has passed this time.

Jul 01 '22 05:07 xu1zhou

It's possible to give run_command a lower logger level to avoid log duplication in this case. But it will also affect all the other run_command functions.

Jul 05 '22 07:07 xu1zhou

@xu1zhou Yes, setting logging level will affect all the functions which use run_command. The default log level is debug, so how about to set the logs of run_command to trace level? For example, log.trace(f"Returning output: [{output}]") If someone want to see this log, he/she can set the log level to trace without change many functions' parameter value to True.

Jul 05 '22 08:07 gyohuangxin

@xu1zhou Do you have any updates?

Aug 02 '22 02:08 gyohuangxin

@xu1zhou Do you have any updates?

Sorry, busy with some other thing these day. I would have a update this week.

Aug 02 '22 02:08 xu1zhou

@xu1zhou Don't worry about this, thanks.

Aug 02 '22 03:08 gyohuangxin

Closing for inactivity. Feel free to reopen this when ready.

Nov 16 '22 15:11 mum4k