code comments

Results 478 comments of


                                            code

json: replace literal string to constexpr and force Streamer to use simple output abstraction

Seems @alyssawilk still on vacation. Let's assign this to another senior maintainer. /assign-from @envoyproxy/senior-maintainers

json: replace literal string to constexpr and force Streamer to use simple output abstraction

/assign-from @envoyproxy/senior-maintainers

tools: simplify the format api to remove unnecessary xfrom related logic

/retest

tools: simplify the format api to remove unnecessary xfrom related logic

/retest

tools: simplify the format api to remove unnecessary xfrom related logic

> Gentle ping @phlax > > > > /wait > > > > Thanks for the ping. FWIW, the /wait means to wait the author to update the PR. /wait-any...

tools: simplify the format api to remove unnecessary xfrom related logic

Will create related clean up PR this weekend. :)

filter_state: add new envoy.hashable_string object factory

Before to start the fixing, did we get a conclusion about the original problem? Ideally, the connect upgrade should ensure the filter state should be set only once?

filter_state: add new envoy.hashable_string object factory

So, as my previous guession, part of requests don't upgrade to connect? (Not use connect)

Cannot Generate Compile Commands After Building Envoy on Ubuntu

@mtmucha Hi, thanks for reporting this. I think this is because we change the active env of our CI recently and you patch is the correct way to fix it....

Cannot Generate Compile Commands After Building Envoy on Ubuntu

> Can the refresh_compdb.sh file be removed and replaced with ci/do_ci.sh refresh_compdb in the tasks.json file? SGTM.