code

Results 478 comments of code

> Can we potentially just include this functionality in the basic auth filter? We could have config in that filter to use different header names, etc. It seems not needed...

> > Basically, they have different logic and configuration format. Or we need to extend the meaning of basic_auth... > > The logic is basically identical just swapping out different...

> I agree there's some similarity though, wouldn't it be weird to implement the features proposed here into BasicAuth filter since the responsibility of the filter would no longer be...

Will this PR a API only PR or complete PR? I think we basically get aggrement on the API. If this is a API only PR, then please change the...

> I was thinking to pile up the commits for the implementation in this PR too after the API agreement. (but, let me know if the other way is recommended...

And I just find another problem, seems the [SPIFFE bundle map](https://docs.google.com/document/d/13KHycYIfRC-g42aEfo4_4inF_WauCXOBgZAcUGuxdgs/edit#heading=h.o2sg9lu1e74v) is still a `Draft`. Is this OK to accept this implementation? cc @alyssawilk