code

Results 478 comments of code

Hi, @mattklein123 could you take a look to this PR first when you have free time? Thanks. :) Does this make sense? This PR mainly does follow changes: - split...

> Do you feel we have good coverage via existing tests or is there more coverage that we could have? I would imagine the existing tests cover this code pretty...

This code is covered pretty good by current tests. Although I have a worry. This PR change/fix a simple behavior, but no one test was broken. Seem at least I...

> How does Envoy and xDS connect with each other? By a long connection. > Does Envoy send gRPC requests to xDS periodically? No. Envoy will send a stream request...

I have encountered similar problem before. **But I am not sure if it's same issue with yours**. My issue is caused by the the lost of connection contract. I configured...