code
code
> Thanks @wbpcode 🥳 > > For this new repository, what is the process for adding a new module? Will there be a proposal process to add new modules so...
Yeah, this is an unexpected change of the output. In the original implmentation, we convert this to string based on the order of the flag index. In the new implementation,...
> To confirm, this does not change behavior... instead it changes how the behavior is implemented. Is that right? Yeah.
cc @htuch
> Interesting. I'm rusty on nlohmann -- what's the functional difference? You are goign to add unit tests for the new way of calling the sanitizer, right? The behavior of...
> So if I have two different same-length strings that are completey invalid utf-8 then this impl will alias them together? Yeah. You cannot expect anything from invalid utf-8.
> Yes I can :) > > I can expect that the serializer generates a byte sequence that's legal json, that deserializes into the original bytes. That's what the current...
I just found the json_loader use similar way to suppress exceptions. 😆 https://github.com/envoyproxy/envoy/blob/main/source%2Fcommon%2Fjson%2Fjson_internal.cc#L571-L576