envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Did flag `uf_urx` change to `urx_uf`?

Open zbintliff opened this issue 1 year ago • 10 comments

If you are reporting any crash or any potential security issue, do not open an issue in this repo. Please report the issue via emailing [email protected] where the issue will be triaged appropriately.

Title: *Did flag uf_urx change to urx_uf? *

Description: Our dashboard are no longer working and we realized because the flag is now urx_uf. We are using istio 1.24 and envoy v1.32.

uf first makes sense as it is the general error with the urx being more details.

zbintliff avatar Mar 10 '25 15:03 zbintliff

I think this is a combination of UF and URX, and it is possible that the order is changed during the combination in data plane.

cc @wbpcode

botengyao avatar Mar 11 '25 15:03 botengyao

Great thank you! I also opened a ticket with DD to see if something changed. But I believe they pull it right from the prom endpoint.

zbintliff avatar Mar 11 '25 19:03 zbintliff

@zbintliff Is this issue resolved? If so, shall we close it?

RyanTheOptimist avatar Mar 17 '25 22:03 RyanTheOptimist

No, I was waiting for the team to chime in if it changed. We are only seeing the new way now.

zbintliff avatar Mar 17 '25 22:03 zbintliff

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 17 '25 00:04 github-actions[bot]

Yeah, this is an unexpected change of the output. In the original implmentation, we convert this to string based on the order of the flag index. In the new implementation, we convert this to string based on the order of setting flag.

I think this could be treat as a bug and fixed it with a minor PR.

wbpcode avatar Apr 17 '25 06:04 wbpcode

Ok, we updated our dashboard to include both ways. We just weren't sure which is correct and want to monitor the correct metric. Thanks for your help. We will follow along.

zbintliff avatar Apr 17 '25 14:04 zbintliff

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 17 '25 16:05 github-actions[bot]

@wbpcode Does it needed to be tracked as a bug and needs to be fixed or do we think that the new behavior is acceptable as its just an ordering change?

agrawroh avatar May 17 '25 17:05 agrawroh

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 17 '25 00:06 github-actions[bot]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 20 '25 12:07 github-actions[bot]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

github-actions[bot] avatar Jul 27 '25 12:07 github-actions[bot]