Thomas Moore

Results 14 comments of Thomas Moore

@fujitatomoya - I don't see anything obvious as to why this would fail on the Windows platform. However, I don't readily have access to a Windows-based development environment to try...

@fujitatomoya - it looks like that didn't fix it. While it shouldn't be an issue, the implementation of `struct TypeAdapter` would generally be considered dangerous because it performs blind `memcpy`...

@fujitatomoya - I noticed that the Windows build had some test failures, and while looking into that, I noticed that there were some similar issues to this introduced as part...

@fujitatomoya - it looks like #330 only updated the [rclpy/executors](https://github.com/ros2/examples/tree/rolling/rclpy/executors) examples but not any of the other `rclpy` examples (e.g. [rclpy/topics/minimal_publisher/examples_rclpy_minimal_publisher/publisher_local_function.py](https://github.com/ros2/examples/blob/rolling/rclpy/topics/minimal_publisher/examples_rclpy_minimal_publisher/publisher_local_function.py)).

>I was thinking about this use case and I believe relying on the processing order in the executors is fragile. I would agree with this statement for the standard executors....

@wjwwood - thanks for taking the time to provide your thoughts. With much digging into ROS and `rclcpp`, I've come to many of the same conclusions you have presented. >...

For me, the concern is that the executor has behaved in the same manner likely since its inception and certainly across many releases of ROS2, and there is published work...

>To understand this a bit more, can you expand on what the impact you are seeing is? It was clearly enough to get your attention, so I'm curious what caused...

@alsora - to be fair, the `EventsExecutor` does indeed work for the experiment I was performing. However, this issue is more about the fact that the order in which the...

@fujitatomoya - it might be worth adding something to the docs page for the Executors in the Scheduling semantics section: https://docs.ros.org/en/jazzy/Concepts/Intermediate/About-Executors.html#scheduling-semantics