examples icon indicating copy to clipboard operation
examples copied to clipboard
verified publisher icon ros2

Update python nodes SIGINT handling

Open thomasmoore-torc opened this issue 1 year ago • 2 comments

Bug report

rclpy was updated to automatically handle SIGINT as part of this PR which was incorporated into the Humble release: https://github.com/ros2/rclpy/pull/844

The python nodes in the demos repository were subsequently updated via the following PRs, but those changes were never incorporated into the examples repository.

  • https://github.com/ros2/demos/pull/539
  • https://github.com/ros2/demos/pull/555
  • https://github.com/ros2/demos/pull/581

For consistency, and to ensure that an exception is not thrown when SIGINT is passed to the example python nodes, these same changes should be incorporated into this repository.

thomasmoore-torc avatar Feb 29 '24 16:02 thomasmoore-torc

@thomasmoore-torc thanks for creating issue.

https://github.com/ros2/demos/pull/539

i think https://github.com/ros2/examples/pull/330 aligns with?

https://github.com/ros2/demos/pull/555 https://github.com/ros2/demos/pull/581

those seem like missing?

fujitatomoya avatar Mar 01 '24 01:03 fujitatomoya

@fujitatomoya - it looks like #330 only updated the rclpy/executors examples but not any of the other rclpy examples (e.g. rclpy/topics/minimal_publisher/examples_rclpy_minimal_publisher/publisher_local_function.py).

thomasmoore-torc avatar Mar 01 '24 02:03 thomasmoore-torc