Benedikt Franke

Results 536 comments of Benedikt Franke

Thanks for the detailed writeup. Changing the generator to deal with namespaces not in `App\` seems reasonable. Given the implementation is not too convoluted and existing functionality keeps working, I...

Could we focus this proposal on providing a way to mutate many models at once? Please describe the problem statement without suggesting a particular technical solution first.

The original issue description is still formulated partly in terms of a proposed solution. I would prefer not to shoebox our thinking and have the description be solely about what...

I thought about reusing the existing mutation directives such as `@create` or `@delete`, since semantically the operations are equivalent. I am not sure they can just be made smart enough...

Let's keep it simple for now and just default to a single transaction and all-or-nothing semantics. Easier both to implement and to reason about. > do the new directives work...

Given this changes interface signatures, this will be a breaking change. > we need to have a combining type for object and interface type in webonyx/graphql-php We are going to...

@eNzyOfficial great to see you work on more directive magic. For this case, it should be much simpler to have `@upload` implement `ArgResolver`.

Oh, I just noticed the upload is also supposed to store the path in the model. In this case, there is yet another directive interface that might work better than...

Composing `@rename` and `ArgTransformerDirective` should work fine.

Assuming your schema passes `lighthouse:validate-schema`, the directive should be registered and getting called. Can you debug what is happening in `TransformArgsDirective`? I also just added a test to make sure...