Shreyansh Gang
Shreyansh Gang
I have resolved all the conflicts.
@asticode Hi, Apologies for not being active for quite some time. Any update on this one, please. I think all the work is done in this scope. Please let me...
> @shrey-gang could you resolve conflicts with changes that were made in between ? It seems `src/client.js` has conflicts Conflict resolved
@asticode I tried running the coverage test it doesn't fail but yes code coverage is 79% which is low. Need some help here, can you suggest something to improve this.
@asticode Sorry for taking so long in making those changes. I have made all the changes as per your suggestions.
Tried testing the changes using the astilectron bundler but did not succeed in that as the bundler always downloads the astilectron from the master tested go-astilectron part the "Addr" is...
Made some changes in the client connection part, instead of checking the string for "tcp://" or "unix://" I have used net.isIP(). In this way, we don't have to make much...