astilectron icon indicating copy to clipboard operation
astilectron copied to clipboard
verified publisher icon asticode

Handling unix socket connection based on OS

Open shrey-gang opened this issue 6 years ago • 5 comments

Pull Request is partenered with asticode/go-astilectron#191

This will fix issue: asticode/go-astilectron#190

shrey-gang avatar Jun 25 '19 17:06 shrey-gang

I had to merge another PR that moved some stuff around and now your PR conflicts with the master branch. Can you make sure there are no conflicts?

asticode avatar Sep 17 '19 07:09 asticode

I have resolved all the conflicts.

shrey-gang avatar Sep 17 '19 10:09 shrey-gang

@asticode Hi, Apologies for not being active for quite some time. Any update on this one, please. I think all the work is done in this scope. Please let me know if I missed something or there are some more changes required.

shrey-gang avatar Dec 01 '20 06:12 shrey-gang

@shrey-gang could you resolve conflicts with changes that were made in between ? It seems src/client.js has conflicts

asticode avatar Dec 01 '20 09:12 asticode

@shrey-gang could you resolve conflicts with changes that were made in between ? It seems src/client.js has conflicts

Conflict resolved

shrey-gang avatar Dec 01 '20 16:12 shrey-gang