go-astilectron Fix for issue #190

#190 Partnering pull request can be found here: asticode/astilectron#20

Jun 25 '19 17:06 shrey-gang

Coverage remained the same at ?% when pulling 54792fd0a9793a48be99e2ce011acd60c16ae02f on shrey-gang:unixDomainSocket into 12a267a595961346a60d1496fa59e316cc0bfdae on asticode:master.

Jun 25 '19 17:06 coveralls

@asticode I tried running the coverage test it doesn't fail but yes code coverage is 79% which is low. Need some help here, can you suggest something to improve this.

Jul 05 '19 04:07 shrey-gang

@asticode Sorry for taking so long in making those changes. I have made all the changes as per your suggestions.

Sep 11 '19 10:09 shrey-gang

Tried testing the changes using the astilectron bundler but did not succeed in that as the bundler always downloads the astilectron from the master tested go-astilectron part the "Addr" is getting updated properly.

Nov 01 '19 12:11 shrey-gang

When using the bundler, you can use the -a flag to indicate the path to your local astilectron folder. That way, it's your astilectron version that is bundled.

Nov 02 '19 10:11 asticode

Made some changes in the client connection part, instead of checking the string for "tcp://" or "unix://" I have used net.isIP(). In this way, we don't have to make much changes in the go-astilectron part, plus the code looks cleaner. I hope this is correct 🤞

Nov 09 '19 22:11 shrey-gang