Shaanjot Gill

Results 27 comments of Shaanjot Gill

ACA-Py report - RFC0496 https://hackmd.io/@gbeoESqjRxm7oQacVc_3OQ/r1RXkPihK

> Is it `/topic/problem_report` or `/topic/acapy::problem_report`? `/topic/problem_report`

While testing PR #1761 [--wallet-type askar], there are inconsistencies in integration test results. With local von-network [--taa-sample], local tails-server, and running `./run_bdd -t @taa_required`, out of 6 test runs I...

@TimoGlastra I have discovered an issue with `pyld` `normalize` which is used to generate `document_statements` here: https://github.com/hyperledger/aries-cloudagent-python/blob/fa749d249a38ab2e5df96d4992ea2ced542290a5/aries_cloudagent/vc/ld_proofs/suites/bbs_bls_signature_proof_2020.py#L97 For this credential ([link](https://tinyurl.com/y5vbu7v7)), the `document_statements` generated by `pyld` is missing this: ```...

@TimoGlastra This test reproduces the issue: https://github.com/hyperledger/aries-cloudagent-python/blob/1f59a056bbf7a489fcefb25510a16832fc165ee5/aries_cloudagent/vc/ld_proofs/suites/tests/test_bbs_bls_signature_2020.py#L89

I am not able to replicate the problem, it is working correctly on my end. I tried with `bls12381g2` key [wallet_only] and without in wallet. Also tried with a different...

PR #1970 should fix this.

I think we can revert [changes](https://github.com/hyperledger/aries-cloudagent-python/blob/960aa912488ec4a6a126de05e4fab1f94aab4287/aries_cloudagent/core/conductor.py#L455) made to `conductor` in PR#1970 due to the changes made to `oob_record` in this PR.

Shouldn't `image_url` also be included at https://github.com/hyperledger/aries-cloudagent-python/blob/a7d839a142f99d9ea04afbe41d296f73f4afafec/aries_cloudagent/protocols/out_of_band/v1_0/manager.py#L231

@Zzocker You are missing a trailing `,` [should be `image_url=image_url,`] at https://github.com/hyperledger/aries-cloudagent-python/blob/075a2d184ad0575fcbe514094fdbecbb04e24a97/aries_cloudagent/protocols/out_of_band/v1_0/manager.py#L239 You can run `python -m black ./aries_cloudagent` inside aries-cloudagent-python directory to check and fix formatting issues.