aries-cloudagent-python icon indicating copy to clipboard operation
aries-cloudagent-python copied to clipboard
verified publisher icon hyperledger

include image_url in oob invitation

Open Zzocker opened this issue 3 years ago • 4 comments

include image_url in out-of-band invitations.

Signed-off-by: Pritam Singh [email protected]

Zzocker avatar Oct 06 '22 06:10 Zzocker

Shouldn't image_url also be included at https://github.com/hyperledger/aries-cloudagent-python/blob/a7d839a142f99d9ea04afbe41d296f73f4afafec/aries_cloudagent/protocols/out_of_band/v1_0/manager.py#L231

shaangill025 avatar Oct 06 '22 18:10 shaangill025

@shaangill025 oh, I missed out when use_public_did=true, amended the commit, and forced pushed it.

Zzocker avatar Oct 06 '22 19:10 Zzocker

@Zzocker You are missing a trailing , [should be image_url=image_url,] at https://github.com/hyperledger/aries-cloudagent-python/blob/075a2d184ad0575fcbe514094fdbecbb04e24a97/aries_cloudagent/protocols/out_of_band/v1_0/manager.py#L239

You can run python -m black ./aries_cloudagent inside aries-cloudagent-python directory to check and fix formatting issues.

shaangill025 avatar Oct 06 '22 19:10 shaangill025

Can you please update the this PR?

swcurran avatar Oct 14 '22 13:10 swcurran

Apologies -- I didn't get this merged before another came through. I'm not sure why I can't update the base branch, but if you could do that, I'll get this merged. Thanks!

swcurran avatar Oct 17 '22 21:10 swcurran

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Oct 18 '22 04:10 sonarqubecloud[bot]