sha-ron

Results 7 comments of sha-ron

> > What is the reason for doing those changes in earlgrey_1.0.0 branch? > > This PR (+ #28491 and #28194 , #28493) are in support of #28494, which allows...

Thank you @a-will, @moidx for the review and help with the CI failures. I added constrains on the configurations as suggested. Hopefully Ci will pass now.

> @sha-ron should this change be eventually cherry-picked over to the `earlgrey_1.0.0` branch too? Yes, it should be merged also to earlgrey_1.0.0 branch (it is required for GLS simulation).

Thank you @timothytrippel. It looks like CI is failing over FPGA checks. I use 'if (kDeviceType == kDeviceSilicon || kDeviceType == kDeviceSimDV)' so I am not sure if/how it is...

I see now:( It looks like it is related to the pad attribute definition in the open source https://github.com/lowRISC/opentitan/blob/master/hw/ip/prim_generic/rtl/prim_generic_pad_attr.sv#L53 that is different. Not sure what is the reason for this...

> Thanks a lot @a-will for your feedback, this is really appreciated! > > @sha-ron , I took the liberty to directly update this PR with an implementation that follows...

Thank you for the review @rswarbrick. CMD_INFO (that includes read_pipeline_mode field) is actually a set of registers and the test has internal loop over a few commands so I am...