Sergey Semenov comments

Results 15 comments of


                                            Sergey Semenov

[SYCL][ABI-break] Remove host_half_impl::half

LGTM overall, but I think it makes sense to rename `half_v2` to just `half` now that the "v1" version is gone.

[SYCL][HIP] Implement PI_DEVICE_INFO_ATOMIC_64 for HIP

@pgorlani The changes looks good, but there are now unexpected passes in testing. Is there an llvm-test-suite PR for enabling those two tests?

[SYCL][HIP] Implement PI_DEVICE_INFO_ATOMIC_64 for HIP

/verify with https://github.com/intel/llvm-test-suite/pull/1094

[SYCL][ABI-break] Promote extended CG/handler members

I'm planning to remove the extended member mechanism in a separate follow-up PR, just so it would be easier to recover it if we need to add new members to...

[SYCL][ABI-break] Promote extended CG/handler members

@smaslov-intel Could you please review?

[SYCL][ABI-break] Promote extended CG/handler members

@steffenlarsen Could you please merge this one?

[SYCL][ABI-break] Promote extended CG/handler members

Looks like this introduced a post-commit failure, looking into it

[SYCL] Use built-ins to retrieve kernel information

This is a draft PR, the built-in path hasn't been tested since their support isn't ready yet.

[SYCL] Use built-ins to retrieve kernel information

@aelovikov-intel Could you please have another quick look? There were a couple of minor changes since your approval (removing the vector header from kernel_desc.hpp & using the new entry point...

[SYCL] Use built-ins to retrieve kernel information

> In my local testing I marked all the entry point functions as static functions since the attribute will throw an error if applied to non-static member function. Can we...