llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL] Use built-ins to retrieve kernel information

Open sergey-semenov opened this issue 1 year ago • 1 comments

Using built-ins is going to be the preferred way to fetch kernel information, while integration headers are still going to be used for cases where built-ins are unavailable (i.e., different host compiler).

sergey-semenov avatar Aug 14 '24 12:08 sergey-semenov

This is a draft PR, the built-in path hasn't been tested since their support isn't ready yet.

sergey-semenov avatar Aug 14 '24 12:08 sergey-semenov

@aelovikov-intel Could you please have another quick look? There were a couple of minor changes since your approval (removing the vector header from kernel_desc.hpp & using the new entry point attribute along with built-ins).

sergey-semenov avatar Sep 04 '24 17:09 sergey-semenov

In my local testing I marked all the entry point functions as static functions since the attribute will throw an error if applied to non-static member function. Can we make that change in this PR as well? @tahonermann can explain it better but it is our understanding that it is an existing bug that these functions are not already marked as static,

I don't see any reason not to make that change, they probably should have been static from the start. Done.

sergey-semenov avatar Sep 05 '24 15:09 sergey-semenov