llvm icon indicating copy to clipboard operation
llvm copied to clipboard
verified publisher icon intel

[SYCL][ABI-break] Remove host_half_impl::half

Open raaiq1 opened this issue 3 years ago • 1 comments

raaiq1 avatar Aug 04 '22 17:08 raaiq1

@cperkinsintel request for review

raaiq1 avatar Aug 10 '22 21:08 raaiq1

LGTM overall, but I think it makes sense to rename half_v2 to just half now that the "v1" version is gone.

sergey-semenov avatar Aug 12 '22 16:08 sergey-semenov

LGTM overall, but I think it makes sense to rename half_v2 to just half now that the "v1" version is gone.

Would it be cleaner to do that in a separate PR though?

aelovikov-intel avatar Aug 12 '22 16:08 aelovikov-intel

I agree

raaiq1 avatar Aug 12 '22 20:08 raaiq1

Updated files to rename half_v2 to half

raaiq1 avatar Aug 15 '22 17:08 raaiq1

CI failure is unrelated to PR: Assert/assert_in_simultaneous_kernels.cpp

raaiq1 avatar Aug 18 '22 17:08 raaiq1