Scott Hart

impl(storage): make RestClient http transport the default

5

Part of the work for #9659 - - - This change is [](https://reviewable.io/reviews/googleapis/google-cloud-cpp/9680)

Make RestClient default http transport implementation for GCS

1

Add option to GCS to choose between new internal rest library or legacy implementation for http transport, defaulting to new rest library. Legacy implementation option will remain available for 3...

Kokoro "No such file or directory"

2

``` ----------------------------------------------------- | Download and compile dependencies using vcpkg | ----------------------------------------------------- Detecting compiler hash for triplet "x64-osx"... The following packages will be built and installed: abseil[core]:x64-osx -> 20211102.1 benchmark[core]:x64-osx ->...

grpc_credential_types failed with RST_STREAM

1

``` 2022-08-04T14:57:59.038944000Z [DEBUG] GenerateAccessToken() > status=INTERNAL: Received RST_STREAM with error code 2 (./google/cloud/internal/log_wrapper.h:94) libc++abi: terminating with uncaught exception of type std::runtime_error: Error in non-idempotent operation GenerateAccessToken: Received RST_STREAM with error...

Remove deprecated BigQueryRead streaming update function

1

We will provide a backwards compatible, yet deprecated, streaming update function for BigQueryRead in `bigquery_read_connection.h` until a year from its deprecation. It was deprecated in 2022/02, so it will be...

Return ErrorCredentials in lieu of StatusOr<Credentials>

1

In `google/cloud/internal/unified_rest_credentials.cc` There are opportunities to refactor some of the helper functions to return an `ErrorCredentials` containing the `Status` rather than as part of a `StatusOr`.

Relocate OAuth2 support from storage to common

1

OAuth2 support is currently coupled with storage. With the new REST library and future client libraries with REST transport, the OAuth2 files and types are to be relocated to `google/cloud/internal`...

REST: refactor moving bytes between buffers

1

In `CurlImpl::WriteToUserBuffer` we juggle bytes between 3 different buffers, look to refactor this such that all buffers are represented as `absl::Span` possibly like: ``` std::pair CopyWithSpill(absl::Span destination, absl::Span spill, absl::Span...

REST: consider using a circular buffer for CurlImpl spill buffer

1

The spill buffer is currently implemented as an array which requires a memmove every time we read some bytes from it. Using a circular buffer would avoid this.

The `generate-libraries` build currently detects changes in existing files or adding of new files, but it doesn't account for extraneous files that should not exist. One possible solution would to...