google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard
verified publisher icon googleapis

Return ErrorCredentials in lieu of StatusOr<Credentials>

Open scotthart opened this issue 3 years ago • 1 comments

In google/cloud/internal/unified_rest_credentials.cc There are opportunities to refactor some of the helper functions to return an ErrorCredentials containing the Status rather than as part of a StatusOr.

scotthart avatar Feb 17 '22 03:02 scotthart

Punt for now, will revisit later.

coryan avatar Jul 14 '22 18:07 coryan

We think this is done. Scott will write the right comment.

coryan avatar Jan 04 '23 19:01 coryan

Scott will review.

coryan avatar May 03 '23 18:05 coryan

fixed in #8400

scotthart avatar May 03 '23 18:05 scotthart