Marius Posta comments

Results 39 comments of


                                            Marius Posta

Panic when running UNION on SHOW BACKUP queries as non-root user

Thanks for reporting this issue, it's a very interesting bug.

Panic when running UNION on SHOW BACKUP queries as non-root user

I think the fundamental problem here is that: - these SHOW BACKUP statements run in a `hookFnNode` plan node, because that's how CCL statements are handled, - their `startExec` methods...

scbuildstmt: add secondary index support for ALTER PK

cc @ajwerner @ajstorm: this is a work-in-progress to validate that indeed, making ALTER PRIMARY KEY support secondary indexes (and hence UNIQUEs) isn't that big of a deal. So far, it's...

scbuildstmt: add secondary index support for ALTER PK

I'm going to work on this on a more leisurely pace now, since it's not needed for DMS. This is basically blocked on https://github.com/cockroachdb/cockroach/pull/86326 at this point, and the release...

scbuildstmt: add secondary index support for ALTER PK

This is now ready for review.

scbuildstmt: add secondary index support for ALTER PK

Thanks for taking a look! > Though I don’t see what were the comment bugs and how they were fixed. This PR originally had two commits, the first was merged...

scbuildstmt: add secondary index support for ALTER PK

Thanks for the reviews! I'm going to merge this now, I don't think it will interfere any more with any known or upcoming release/GA blockers. bors r+

rule: changed two dep rules

Whatever it takes. Regardless of this particular issue, I believe that making the column public a non-revertible op makes sense anyway. Go for it!

scbuildstmt: ALTER PK drops rowid column when possible

cc @Xiang-Gu @ajwerner @ajstorm

scbuildstmt: ALTER PK drops rowid column when possible

This error in `TestPrimaryKeyChangeWithOperations` is reproducible locally under stress. Obviously, something's wrong with our plan, but I'm struggling to make sense of it. The nullness errors are thrown when writing...