Marius Posta

Results 39 comments of Marius Posta

Sure! Sorry for not responding sooner. Please give me a few days to get up to date, I'll be more active henceforth, and if I can't, I'll let you know.

I'm not too sure either, but based on my limited understanding of how things are done in clojure, it's OK. Basically, a consequence of the immutability of clojure data structures...

I changed `docopt.core` a bit and replaced `match` with a java class method for JVM interop, see README for more info.

Thanks for the review! Updating this PR with a recent `master` before merging, just to make sure, as this has grown a bit stale.

Thanks for contributing! Were you able to run the `test` and `integrationTestJava` gradle tasks successfully in source-mongo-v2? I checked out your branch and observed multiple integration test failures. Please reach...

Interesting! I searched and found it in the test fixtures, the substring to search for is `"deployment.mode"`. In my PR I hadn't thought of how this would impact the test...

This is ready for review, the only failing checks are connnector version bumps.

> I'm not sure what this PR accomplishes on top of that other than to limit the list of supported vars? Limiting the supported vars is not the goal per...

No worries! Like I said it's not urgent and I only just got the build to pass. Thanks for taking a look.