Marius Posta

Gaah I keep forgetting that write-only isn't as strict as it sounds and actually allows reading data when it's for the purpose of doing a write, so to speak (because...

Hmm, that doesn't seem to have done the trick. Let's look at this together tomorrow.

I added what I thought was a decent rule but I'm still getting ``` --- FAIL: TestPrimaryKeyChangeWithOperations (5.60s) test_log_scope.go:162: test logs captured to: /Users/mariusposta/go/src/github.com/cockroachdb/cockroach/tmp/_tmp/484b17052552acaa61586f932b2ab60e/logTestPrimaryKeyChangeWithOperations675002425 test_log_scope.go:80: use -show-logs to present logs...

The debugger tells me these errors happen in `UpdateRow` on the old primary index just after if was swapped out. I guess any UPDATE at that point needs to update...

This PR uses a transient primary index in ALTER PRIMARY KEY when dropping the rowid column. The plan looks good from what I can tell, and the schema changer is...

I've rebased and added a rule which makes the old primary index reach absent before the new primary index is public, when a third (transient) primary index is involved. The...

This came along nicely. I'm closing this in favour of https://github.com/cockroachdb/cockroach/pull/86071, which is the same thing minus one or two commits, and minus the flakes, and with updated commit messages....

Schema LGTM for: - clusterversion: remove DeleteCommentsWithDroppedIndexes - clusterversion,sql: remove MVCCIndexBackfiller - clusterversion,sql: remove EnableDeclarativeSchemaChanger - clusterversion,sql: remove RowLevelTTL - clusterversion,sql: remove SuperRegions

Let's table this until the next release. This was a valiant and impressive effort, but time has run out. If it's any consolation, we experienced something similar in the last...

* **#37794** * **#37793** * **#37611** * **#37610** * **#37609** * **#37608** * **#37607** * **#37606** * **#37605** * **#37604** * **#37603** 👈 * `master` This stack of pull requests...