Ricardo Noriega

Results 55 comments of Ricardo Noriega

Something is conflicting with vendor/modules.txt Should we run `go mod vendor` again?

Looks good to me, I'll let one more reviewer to evaluate, and I'll tag it.

/lgtm This PR reveals some underlying shutdown issues in MicroShift. I've created a new JIRA ticket for it (https://issues.redhat.com/browse/USHIFT-316)

This has been fixed in main branch: ``` [root@maxwell ~]# oc create clusterrolebinding oidc-reviewer --clusterrole=system:service-account-issuer-discovery --group=system:unauthenticated clusterrolebinding.rbac.authorization.k8s.io/oidc-reviewer created [root@maxwell ~]# curl -k $(oc get --raw /.well-known/openid-configuration | jq -r .jwks_uri)...

I like this idea. It happened to me when I was working on the service node port range option!