microshift icon indicating copy to clipboard operation
microshift copied to clipboard

USHIFT-213: OpenShift kube-apiserver enablement skipped

Open benluddy opened this issue 3 years ago • 3 comments

just a hack to get started identifying follow-up work

/hold

benluddy avatar Jul 27 '22 14:07 benluddy

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Jul 27 '22 14:07 openshift-ci[bot]

/retest

benluddy avatar Aug 16 '22 19:08 benluddy

/retest

benluddy avatar Aug 16 '22 22:08 benluddy

/retest

benluddy avatar Aug 17 '22 19:08 benluddy

/retest

benluddy avatar Aug 18 '22 13:08 benluddy

Something is conflicting with vendor/modules.txt

Should we run go mod vendor again?

oglok avatar Aug 18 '22 14:08 oglok

https://github.com/openshift/microshift/pull/862 just merged -- rebased.

benluddy avatar Aug 18 '22 14:08 benluddy

/retest

oglok avatar Aug 18 '22 15:08 oglok

@benluddy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 18 '22 15:08 openshift-ci[bot]

/hold cancel

benluddy avatar Aug 18 '22 20:08 benluddy

Looks good to me, I'll let one more reviewer to evaluate, and I'll tag it.

oglok avatar Aug 19 '22 09:08 oglok

/lgtm

oglok avatar Aug 19 '22 11:08 oglok

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, oglok, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 19 '22 11:08 openshift-ci[bot]