microshift icon indicating copy to clipboard operation
microshift copied to clipboard

kube-apiserver: don't setup the oauth endpoint

Open stlaz opened this issue 3 years ago • 6 comments

This seems unused.


I'm just getting to know to codebase, this code seemed redundant.

stlaz avatar Aug 09 '22 13:08 stlaz

ohh I believe you're correct, @oglok ^

mangelajo avatar Aug 10 '22 12:08 mangelajo

/approve

mangelajo avatar Aug 10 '22 12:08 mangelajo

Linking with the JIRA issue: USHIFT-265

ggiguash avatar Aug 10 '22 12:08 ggiguash

/lgtm

oglok avatar Aug 10 '22 16:08 oglok

/retest-required

Remaining retests: 2 against base HEAD b893b302d9ab5e040b39ab30fe440fe750a8cf03 and 8 for PR HEAD 93e2b1115af962e14bf5ca9e3054d035f7c38a37 in total

openshift-ci-robot avatar Aug 10 '22 17:08 openshift-ci-robot

/lgtm

mangelajo avatar Aug 11 '22 09:08 mangelajo

/retest

mangelajo avatar Aug 11 '22 09:08 mangelajo

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangelajo, oglok, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [mangelajo,oglok]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 11 '22 09:08 openshift-ci[bot]

@stlaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 11 '22 09:08 openshift-ci[bot]