Mark Eastwood

Results 13 comments of Mark Eastwood

> > I will have to provide longer feedback in future, but just making a few quick notes before our meeting. I have a few concerns: > > 1. I...

I've added functions to add/drop the area column as discussed. Also finished adding tests, so marked it as ready for review.

> Thanks @measty. Please can you address the comments? @shaneahmed the docstring-related comments have been addressed

> @measty It has since occurred to me that we may need to add a column for annotation type (e.g. an integer which corresponds to an enum) for filtering annotations...

> I've make a few comments / suggestions of things. Mostly just suggesting alternative naming for things. All the comments have been addressed now, I think

It looks like an environment issue. Some similar issues when using conda have been fixed by pip uninstalling openslide-python and re-installing it using conda instead: ``` pip uninstall openslide-python conda...

I think this also needs a fix along similar lines for read_rect

I've added a few changes to this PR too. - fix for read_rect along similar lines to read_bounds (it was bugged in the same way) - a few changes to...

Hi roger, Thanks for the suggestion! This may align with some other work i'm looking at doing on the tileserver, so if I get a chance to work this in...

This is being added in #825