tiatoolbox icon indicating copy to clipboard operation
tiatoolbox copied to clipboard

🐛 Fix `TIFFWSIReader` `read_bound`

Open vqdang opened this issue 2 years ago • 9 comments

image

Emergency bugfix per @John-P request. The culprit is reading bound doesn't use the adjusted bounds as have been done in OpenSlideReader

vqdang avatar Jan 29 '24 15:01 vqdang

Thanks @vqdang and @John-P Please can you add a simple test to make sure this produces expected results.

shaneahmed avatar Feb 02 '24 11:02 shaneahmed

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.86%. Comparing base (621a857) to head (a2c8afe). Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #777      +/-   ##
===========================================
- Coverage    99.89%   99.86%   -0.04%     
===========================================
  Files           69       69              
  Lines         8650     8650              
  Branches      1653     1654       +1     
===========================================
- Hits          8641     8638       -3     
- Misses           1        4       +3     
  Partials         8        8              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 02 '24 12:02 codecov[bot]

Please can you also check if it is related to #499 ?

shaneahmed avatar Feb 02 '24 14:02 shaneahmed

I have added a simple test but not completely sure if it fully tests for the fixed bug. @vqdang @John-P I'd appreciate it if you can give the test a review.

Abdol avatar May 13 '24 14:05 Abdol

A kind follow up @vqdang @John-P. I'd appreciate it if you can give the test a review. Thanks!

Abdol avatar Jun 07 '24 05:06 Abdol

I think this also needs a fix along similar lines for read_rect

measty avatar Jun 24 '24 15:06 measty

A kind follow up @vqdang @John-P. I'd appreciate it if you can give the test a review. Thank you!

Abdol avatar Jun 25 '24 15:06 Abdol

I've added a few changes to this PR too.

  • fix for read_rect along similar lines to read_bounds (it was bugged in the same way)
  • a few changes to make the reader compatible with a wider variety of tiffs
  • a change to metadata in wsireader that fixes some performance issues on some wsis

measty avatar Jun 27 '24 22:06 measty

After updating the sample OME TIFF, the bug can be reproduced using the existing level consistency tests. So, I have removed the newly-added test. This PR should be good to go now.

Abdol avatar Jun 28 '24 15:06 Abdol