Matt Burgess
Matt Burgess
Looks like you have some Checkstyle errors, please run your maven command with the `-Pcontrib-check` before pushing commits, thanks!
Can this be closed if #6364 replaces it?
The latest commit didn't fix the errors, going to give it another try tomorrow, once they pass we should be good to go
Looks like the Windows test is passing with the last commit.
This has merge conflicts that need to be addressed, we're not using `includePrimaryKeys` anymore AFAIK
Looks good. Is there any way to add a unit test for this?
Reviewing...
+1 LGTM, verified os.getpid() works and that Xerces is still included. Thanks for the upgrade! Merging to main
+1 LGTM, thanks for the improvments and review! Merging to main
+1 LGTM, thanks for the review @mark-bathori and thanks for the improvements @exceptionfactory ! Merging to main