nifi icon indicating copy to clipboard operation
nifi copied to clipboard

NiFi-10576 - ParquetRecordSetWriter doesn't write avro schema to attribute

Open thenatog opened this issue 3 years ago • 1 comments

Summary

NiFi-10576

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • [x] Pull Request title starts with Apache NiFi Jira issue number, such as NiFi-10576
  • [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NiFi-10576

Pull Request Formatting

  • [x] Pull Request based on current revision of the main branch
  • [ ] Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • [ ] Build completed using mvn clean install -P contrib-check
    • [ ] JDK 8
    • [x] JDK 11
    • [ ] JDK 17

Licensing

  • [ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • [ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • [ ] Documentation formatting appears as expected in rendered files

thenatog avatar Oct 12 '22 17:10 thenatog

Looks good. Is there any way to add a unit test for this?

mattyb149 avatar Oct 12 '22 18:10 mattyb149

Thanks, if the avro.schema attribute is coming through on flowfiles coming out of the runner, then that sounds good to me. The simplest test would be to see that the attributes are now returned from the method I added, but I noticed that at run time it didn't come through until I added a schema cache service. Entirely possible I didn't understand how the schemas worked, and that setting it to use schema name(?) should work.

thenatog avatar Dec 09 '22 17:12 thenatog